Check for error responses when using callbacks

rickfast · Sep 16, 2016 · 24b7026 · 24b7026
1 parent a4cfd6a
commit 24b7026
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/main/java/com/orbitz/consul/util/Http.java b/src/main/java/com/orbitz/consul/util/Http.java
@@ -60,7 +60,11 @@ public static <T> void extractConsulResponse(Call<T> call, final ConsulResponseC
         call.enqueue(new retrofit2.Callback<T>() {
             @Override
             public void onResponse(Call<T> call, Response<T> response) {
-                callback.onComplete(consulResponse(response));
+                if (response.isSuccessful()) {
+                    callback.onComplete(consulResponse(response));
+                } else {
+                    callback.onFailure(new ConsulException(response.code(), response));
+                }
             }
 
             @Override
@@ -75,7 +79,11 @@ public static <T> void extractBasicResponse(Call<T> call, final Callback<T> call
 
             @Override
             public void onResponse(Call<T> call, Response<T> response) {
-                callback.onResponse(response.body());
+                if (response.isSuccessful()) {
+                    callback.onResponse(response.body());
+                } else {
+                    callback.onFailure(new ConsulException(response.code(), response));
+                }
             }
 
             @Override