OSGi Support?

[sakno]

Life would be easier if consul-client will support OSGi. Today I have to wrap your library into OSGi bundle using many manipulations: excluding some dependencies, adding OSGi-compliant MANIFEST.MF and many other things.

[rickfast]

I can try to get to this in the next few weeks. Pull requests welcome.

[sakno]

I checked your dependencies. slf4j-api, Google Guava, jax-rs, javax-annotation and Jackson are OSGi bundles. So your dependencies are full OSGi-compliant, this is a good news. But pom.xml of consul-client must be rewritten completely: all dependencies should be declared as <scope>provided</scope>. This is not suitable for non-OSGi applications (each consumer must declare your dependencies explicitly in their POM as <scope>compile</scope>). I'll think about it.

[gjesse]

So IMO this library probably shouldn't support OSGI - it seems like the primary use case is for non-OSGI apps, so the burden should probably be on those who want it.

One option would be to publish your wrapper with dependencies/exclusions setup, with the correct manifests in a separate repo that pulls in consul-client.

Ultimately it's @rickfast's call but just wanted to drop my 2c in.

[lburgazzoli]

I would like to hep here but first I'd like to understand why should the dependencies be declared as provided ?

[rickfast]

I don't know enough about OSGi bundles to answer this. We can't change the main generate me pom to declare dependencies in the provided scope because that will break most of the clients.

[lburgazzoli]

I do not think is is needed, as far as I know, once you have a proper manifest you should be ready to go (unless you have some specific requirement for calss-loading etc)

[sakno]

maven-bundle-plugin requires provided scope for artifacts which should not be embedded into output bundle. This technique used for libraries which are not bundlized but must be shipped with bundle.

[lburgazzoli]

This is true if you enable Embed-Dependencies, but you can configure it to include only the dependencies you need or to skip transitive ones (Embed-Transitive).

[rickfast]

I'll defer to you guys on this. My only requirement is that this work doesn't affect the default published artifact

[lburgazzoli]

@rickfast definitively ;)

[lburgazzoli]

@rickfast any chance to do a new release which include this OSGi enhancement ?

[rickfast]

0.10.2 published to bintray. Central will have to be later this week

[lburgazzoli]

@rickfast thx