This repository was archived by the owner on Jul 27, 2023. It is now read-only.
Introduced acl and auth support #122
Merged
+133
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to allow the creation of a Consul instance, without 'pinging' the server with AgentClient This allows the creation of a Consul instance while the Consul service is unavailable. This is useful when the Consul instance is created at application startup (Spring Framework style), and we want the application to be able to start (not fail) even when Consul is not available.
…c Authentication (providing username+password) Added support for the Consul ACL : a token can be provided to the Consul.Builder, this token will be added to every request as a query parameter. Added support for Basic Authentication : in case you setup a reverse proxy in front of the Consul service (for additional security to the ACL, or as an alternative to the Consul ACL) In both case, an Interceptor is added to the Retrofit client.
…the project builds with Java 7
|
Awesome thanks! |
|
Thank you for merging so fast. |
|
Sure. Once I'm in the office |
|
0.11.2 is available |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basic support for the Consul ACL (providing token) + support for Basic Authentication (providing username+password)
Added support for the Consul ACL : a token can be provided to the Consul.Builder, this token will be added to every request as a query parameter.
Added support for Basic Authentication : in case you setup a reverse proxy in front of the Consul service (for additional security to the ACL, or as an alternative to the Consul ACL)
In both case, an Interceptor is added to the Retrofit client.