This repository was archived by the owner on Jul 27, 2023. It is now read-only.
Build non-shaded jar as well as shaded #162
Merged
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, thanks for this very useful lib!
We are having a bit of trouble using it, unfortunately, because it's shaded-only. While shading a JAR can be useful to solve some problems, it can also cause different issues to crop up.
For example, when using the shaded JAR with
sbt-assembly
, you get conflicting files:A simple solution to this is to allow the user to pick whether they want to use the shaded JAR or a non-shaded JAR. This PR tweaks the
maven-shade-plugin
config to build both a shaded and non-shaded JAR according to http://maven.apache.org/plugins/maven-shade-plugin/examples/attached-artifact.html.This does mean that the default JAR is now un-shaded again, and to get the shaded JAR you need to put a
shaded
classifier on your dependency. While this is maybe a little annoying in the short-term, long-term it's closer to what people expect. That is, most people expect JARs to be un-shaded. Having a shaded JAR is an exception and should be treated as such.Please let me know if I can do anything else to get this merged. Thanks!