This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Override default backoff delay for Cache #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 3714976 changes the way the prefix are removed from the key. It works fine for key/subkey pattern but fails when we are looking for the exact key (for intance, "a/b").
* Fix indentation and renumber examples In example 4 there was an extra level of indentation, and there was no example 5, but examples 6, and 7, 8. I fixed the indentation and the numbering gap. * add slight documentation to example 4 I added a single line of documentation to example 4 as per #174. * Revert "Fix indentation and renumber examples"
In example 4 there was an extra level of indentation, and there was no example 5, but examples 6, and 7, 8. I fixed the indentation and the numbering gap.
* Add eclipse project files to .gitignore * Add support for Check-And-Set option to DELETE operation.
Default backoff delay for caches is equal to 10s. Enable this value to be overriden from properties if such a property exists. For instance, "-Dcom.orbitz.consul.cache.backOffDelay=500". I chose to use properties as the code of caches starts to grow fast, some caches already have 4 constructors and i think it could be better to avoid the creation of another one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default backoff delay for caches is equal to 10s.
Enable this value to be overriden from properties if such a property exists.
For instance, "-Dcom.orbitz.consul.cache.backOffDelay=500".
I chose to use properties as the code of caches starts to grow fast, some
caches already have 4 constructors and i think it could be better to avoid
the creation of another one.