This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
[ConsulCache] Set retry threads as deamon #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in caches, retry threads are user threads. Hence, if consul fails, the retry mechanism may prevent the application to stop. We add a thread factory in the executor service to make the retry threads as deamon. This would prevent this issue. Change-Id: I0343c46493d25ed0ab33bead3f8bc9dca57fcaec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in caches, retry threads are user threads.
Hence, if consul fails, the retry mechanism may prevent the application to
stop.
We add a thread factory in the executor service to make the retry threads
as deamon. This would prevent this issue.
see: Thread
Change-Id: I0343c46493d25ed0ab33bead3f8bc9dca57fcaec