Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Race condition when adding listener to ServiceHealthCache #269

Merged
merged 10 commits into from
Nov 12, 2017
Merged

Race condition when adding listener to ServiceHealthCache #269

merged 10 commits into from
Nov 12, 2017

Conversation

maqdev
Copy link
Contributor

@maqdev maqdev commented Nov 12, 2017

Race condition occurs when:

  1. ServiceHealthCache is in state starting
  2. It's finished calling all notifications (ConsulCache.java:96) for already registered listeners
  3. At this point if we add new listener it's notify isn't called immediately, because state is starting
  4. ServiceHealthCache is in state started

@rickfast rickfast merged commit 00fffc4 into rickfast:master Nov 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maqdev @rickfast