This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Add event monitoring #306
Merged
Add event monitoring #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handler will call the callback methods asynchronously to not reduce performance of the API. As the callback methods have default behavior, user may only implement the event they want.
Ask for event callback in Consul creation (optional). Create event handler in Consul and inject it in each client (using base client).
Http class becomes stateful (storing the event handler). Call the handler for each HTTP request with client name, method and query string. EventClient was not fully using Http, so use it (with wrappers when needed).
There is too much duplicated code here, clean it.
Test all methods Sync and Async for: - result because of the refactoring - events Also test consulResponse method.
Monitor cache stop/start, polling success/error.
vandonr
reviewed
Feb 14, 2018
| @@ -0,0 +1,306 @@ | |||
| package com.orbitz.consul.util; | |||
There was a problem hiding this comment.
OPT: break lines between Arrange/Act/Assert sections in tests when they are more than a couple of lines
There was a problem hiding this comment.
Done.
Please tell me if it meets your expectations.
Following review of @Zonkooo, splitting the Arrange/Act/Assert sections would enhance readability.
vandonr
approved these changes
Feb 15, 2018
| @@ -0,0 +1,306 @@ | |||
| package com.orbitz.consul.util; | |||
adericbourg
approved these changes
Feb 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monitor http request and cache events:
Users will be able to implement methods of the callback (only those interesting them) to add custom monitoring (logs, metrics, ...).