Update ETSI TS 103 097 & 102 941 security specs #223
Conversation
| ) | ||
| /** | ||
| * @brief This structure defines the format of a signed certificate request.") | ||
| string(REGEX REPLACE "ScopedCertificateRequest ::=.+signed certificate request." "${_valid_scoped_certificate_request}" _content "${_content}") |
There was a problem hiding this comment.
It becomes quite hard to see the actual patch this way. I prefer to have a patch file then. Is there a reason why a patch file is inappropriate here?
There was a problem hiding this comment.
No, the complexity only started to explode after beginning that script already so i didn't change it to a patch, but good idea!
DeeJayBro
force-pushed
the
etsi_security_update
branch
2 times, most recently
from
e3d6bf4 to
88b959d
Compare
|
Any update on this? should the asn1 definitions moved to |
DeeJayBro
force-pushed
the
etsi_security_update
branch
from
88b959d to
1cb10e9
Compare
|
@riebl i have rebased the PR and moved the asn1 files to the |
|
I just rechecked, replacing the "old" definitions should also be workable, since the standard extends a few datatypes and moves over to directly to IEEE 1609 but not changing on outer-facing definitions, with all tests still passing on a slate using the new asn.1 files |
|
What is the reason for patching IEEE 1609.2.1? Is it not supported by asn1c? |
|
Yes, without the patch, asn1c is throwing the following fatal errors on compilation: This behaviour seems to be known (see mouse07410/asn1c#194 and vlm/asn1c#400) but there does not seem to be a planned fix on the asn1c roadmap |
|
Thanks for your contribution @DeeJayBro! Side note: Our code generation for ASN.1 has become a little bit messy over the years. I would like to revise it in the foreseeable future. If you have some ideas, please feel free to add them as issue tickets. |
Updates the security-related ASN definitions for TS 102 941 to v2.2.1 and TS 103 097 to v2.1.1.
As the IEEE definitions need some patching and with the introduction of IEEE1609.2.1 in TS 102 941 plus the resulting increase in the amount of files, these were outsourced to a cmake script which also takes care of the patching
Compiling to code needs an asn1c with the following pull request (mouse07410/asn1c#138), as newer ETSI ITS ASN.1 defs make great use of
WITH SUCCESSORS