Small fixes #241
Merged
Small fixes #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riebl
reviewed
Dec 13, 2024
|
An almost perfect PR :-) |
|
I was trying really hard :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
couple of small changes:
vanetza::security::v3::save_certificate_to_file()hascertificateparameterconstin header but notconstin implementation. Adding it there requires thatvanetza::security::v3::serialize()for certificate has this parameter alsoconst. Further, small comment fix.<future>header inclusion fromvanetza/security/v2/sign_service.cppandvanetza/security/v2/signature.hppas it seems not needed here, just invanetza/security/signature.hpp. This was just for my convenience when building library for C++/CLI wrapper, since that does not support<future>and I wanted it in as few places as possible. Please ignore this if you think it is not needed.