Allow overriding graphite metric conversion method #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC the problem here is fractions--Riemann has a rational type, and Graphite doesn't. How about doing an (integer?) check and passing those through unchanged, and coercing other types to (double x)? |
agile
force-pushed
the
increase_precision_of_graphite_events
branch
from
7502d34 to
c8b0e07
Compare
|
@aphyr sounds sensible to me, updated to do that. |
|
Looks great, thank you! |
aphyr
added a commit
that referenced
this pull request
Nov 24, 2015
Allow overriding graphite metric conversion method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some external verifications of what riemann was sending to graphite were failing due to lost precision of some
longmetrics because they're being converted into floats. I'm not sure if there's a good reason to use float vs double so I thought to allow overriding the function used to do the conversion.