Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Final memory values are now available on QAMExecutionResults #1703

Merged
merged 4 commits into from
Nov 28, 2023
Merged

feat: Final memory values are now available on QAMExecutionResults #1703

merged 4 commits into from
Nov 28, 2023

Conversation

MarquessV
Copy link
Contributor

@MarquessV MarquessV commented Nov 27, 2023 •
edited
Loading

Description

closes #1702

Requires rigetti/qcs-sdk-rust#393 to be deployed.

@MarquessV MarquessV marked this pull request as ready for review November 27, 2023 19:09
@MarquessV MarquessV requested a review from a team as a code owner November 27, 2023 19:09
kalzoo
kalzoo approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@kalzoo kalzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending rigetti/qcs-sdk-rust#393

pyquil/api/_qam.py Outdated Show resolved Hide resolved
@MarquessV MarquessV mentioned this pull request Nov 28, 2023
Closed
8 tasks
@rigetti-githubbot
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7089 6222 88% 87% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
pyquil/api/_qam.py 91% 🟢
pyquil/api/_qpu.py 65% 🟢
TOTAL 78% 🟢

updated for commit: d81fc9c by action🐍

notmgsk
notmgsk approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@notmgsk notmgsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

kalzoo
kalzoo approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@kalzoo kalzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚂

pyquil/api/_qam.py Show resolved Hide resolved
@MarquessV MarquessV merged commit a388de0 into master Nov 28, 2023
21 checks passed
@MarquessV MarquessV deleted the return-memory-values branch November 28, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalzoo kalzoo kalzoo approved these changes

@notmgsk notmgsk notmgsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make final memory values from QPU jobs available
4 participants
@MarquessV @rigetti-githubbot @notmgsk @kalzoo