Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: general tooling fixes in support of quil-rs #1812

Closed
wants to merge 4 commits into from

Conversation

antalsz
Copy link

@antalsz antalsz commented Jan 9, 2025

This PR is probably unnecessary but I'm leaving it up as draft until I confirm that

Description

When working on quil-rs, I uncovered some errors when quil-rs is checked with Mypy or Ruff; this PR fixes those small issues.

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@antalsz antalsz self-assigned this Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

🐰 Bencher Report

Branchquil-rs-ci-fixes
Testbedci-runner-linux

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyseconds (s)
test/benchmarks/test_program.py::test_copy_everything_except_instructions📈 view plot
⚠️ NO THRESHOLD
9.32
test/benchmarks/test_program.py::test_instructions📈 view plot
⚠️ NO THRESHOLD
4.11
test/benchmarks/test_program.py::test_iteration📈 view plot
⚠️ NO THRESHOLD
4.21
🐰 View full continuous benchmarking report in Bencher

@antalsz
Copy link
Author

antalsz commented Jan 10, 2025

Confirmed, this is unnecessary – I was misled by some broken CI in quil-rs. Sorry!

@antalsz antalsz closed this Jan 10, 2025
@antalsz antalsz deleted the quil-rs-ci-fixes branch January 10, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant