Sending buffer data is not working! #11 #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! An error has been made in your binary data validation function. In the very first line. When the binary value got into the function, it was checked by obj is! Map && obj is! List, and since obj is TypedData, the function immediately returned the value false, which is why further parsing ended with an error You can easily reproduce this yourself, just try calling emit with the buffer value and make sure that I have slightly modified your function and checked it for performance, after that my server has successfully received binary data. Please review my pool request as soon as possible, thank you
|
Sorry, I accidentally closed the previous pool request |
|
Thanks for your contribution, but is there any test case for this PR? |
Corrected the condition for List data type
Yes, I did a little test for you, please look at isBinary.test.dart in the archive and run it |
jumperchen
added a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! An error has been made in your binary data validation function. In the very first line.
When the binary value got into the function, it was checked by
obj is! Map && obj is! List, and sinceobj is TypedData, the function immediately returned the valuefalse, which is why further parsing ended with an errorYou can easily reproduce this yourself, just try calling emit with the buffer value and make sure that
I have slightly modified your function and checked it for performance, after that my server has successfully received binary data.
Please review my pool request as soon as possible, thank you