Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision of fs namespace #141

Closed
ra-dave opened this issue Jun 8, 2023 · 2 comments
Closed

Collision of fs namespace #141

ra-dave opened this issue Jun 8, 2023 · 2 comments
Assignees
Milestone

Comments

@ra-dave
Copy link

ra-dave commented Jun 8, 2023

I'm trying to utilize bit7z in our product code to evaluate it. I am only using bitarchivewriter.hpp currently. I am getting a namespace collision with the fs namespace as our code also is using that namespace. I'm not sure yet why it's colliding, isn't bit7z's usage of that namespace an internal thing?

@rikyoz rikyoz self-assigned this Jun 9, 2023
@rikyoz rikyoz added this to the v4.0 milestone Jun 9, 2023
@rikyoz
Copy link
Owner

rikyoz commented Jun 9, 2023

Uhm strange!

isn't bit7z's usage of that namespace an internal thing?

Yes, it is, but unfortunately, there are some "semi-internal" classes that belong to the public API and need to use fs::path, hence that namespace had to be declared in a public header too.

I have some possible solutions to this, but I need to verify which might be the best.

Anyway, thanks for pointing out this issue!

@rikyoz
Copy link
Owner

rikyoz commented Oct 1, 2023

Fixed in v4.0.0.

@rikyoz rikyoz closed this as completed Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants