-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hook: "Commit script while keeping the selected transforms" (輸入預變換上屏時保留已接受的候選) #924
Conversation
Essential for Japanese Romaji-based input.
已经支持的功能,请在我发的链结指向的wiki中搜关键字 commit_script_text |
抱歉我描述功能有誤:應為 commit script時保留已接受的漢字 因為製作日文輸入時經常需要進行假名半保留,所以需要在前半部分已經完成compose selection(漢字)的情況下對後半部分保留precompose的預變換(假名) 已經更新最上方的PR描述 |
Style
Style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM。我贊同這是目前沒有且需要增設的功能。但是具體名字似可商榷,不過我也沒有更好的提議。:-)
感謝! 如果 |
這個功能挺好的,不如讓 |
Do we need to keep that optional argument?
原來如此。 已修改成 |
合併了。謝謝。 |
Pull request
Feature
Add Commit script while keeping the transforms: when
commit_script_text_keep_selection
is called, the morphed input goes to the box instead of raw inputs with previously accepted transformations keptEssential for Japanese Romaji-based input.
功能:當
commit_script_text_keep_selection
被調用時(例如:時按下 Return),可實現預變換輸入上屏時保留已選漢字。
比較直接的應用是在使用 Rime 輸入日語時可以將 Romaji 預變換的假名上屏並保留已輸入的漢字。
E.g.
nyuuryokupuroguramu
にゅうりょくぷろぐらむ
にゅうりょく
→入力
⬇️ Press Return ⬇️
Config used here: My customization of gkovacs/rime-japanese.
Unit test
Manual test
Code Review
Additional Info