Code Duplication #22
Merged
Code Duplication #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There’s some code duplication in your main function where you’re calling "LoadDynamicLibrary" with different parameters based on the platform. You could define platform-specific constants for the library name and use them in a single call to "LoadDynamicLibrary".
|
Thanks a lot for pull request. Can you please check duplicates in Termi-GUI? |
Andrej123456789
requested changes
Sep 24, 2024
| try { | ||
| auto func = LoadDynamicLibrary<int(*)(int)>(LIB_NAME, "tmain"); | ||
| func(12); | ||
| } catch (const std::exception& e) { |
There was a problem hiding this comment.
Please remove part of code implementing exceptions, because they are not unnecessary due to following:
a) this is function from C library where exceptions do not exist,
b) errors when loading function is handled in LoadDynmaicLibrary function.
Rest of code is excellent, thank you for this idea!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s some code duplication in your main function where you’re calling "LoadDynamicLibrary" with different parameters based on the platform. You could define platform-specific constants for the library name and use them in a single call to "LoadDynamicLibrary".