Revert bundle asset hash changes #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile size slightly
|
UI bundle preview build successful! ✅ |
|
Build successful! ✅ |
eric-schneider
approved these changes
Dec 17, 2024
|
@colegoldsmith @eric-schneider re:
This is in place on deploys as of 12/13. Next time you push bundle changes it should do a full sync. |
|
Thanks @mlr!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
We wanted to force a re-upload of all asciidoc pages to prod, so we temporarily increased the asset manifest filename size by 2 more characters. This slightly increased the size of each built page to trigger the re-upload.
This PR
Reverts the file name size change in the UI bundle build
Going forward
We should create action to detect any changes to the UI bundle and force all pages to be rebuilt. This will solve the issue of some pages being rebuilt with a new UI and some not, resulting in the unbuilt pages trying to import incorrect asset files.