Workshop -> nit picks and questions #125
Conversation
nuke-web3
added
documentation
| @@ -66,7 +66,7 @@ Your new project consists of: | |||
| - Builds for zkVM program, the publisher app, and any other Rust code. | |||
|
|
|||
| ```sh | |||
| cargo build | |||
| cargo build --release | |||
There was a problem hiding this comment.
Is the only reason we must run this first is because forge is looking to get an Elf.sol that this builds?
Or should we be optimizing here for the forge b next?
There was a problem hiding this comment.
Indeed cargo build generates the ImageID.sol and Elf.sol files, which is the primary reason it needs to run first. I don't know of any way to achieve this just by running forge build or forge test.
I don't see any reason to run with --release, since the performance is not an issue in client-server mode.
There was a problem hiding this comment.
Also --release takes a lot longer to build, so if you're in client/server, it might not be worth it.
|
I'm going to go ahead an close this PR, since I think we discussed we will not merge the change in it. |
WIP - probably a
DO-NOT-MEREGEbut other smaller PRs will reference this oneI will comment on things as I go, and @ people to ask things in this PR along the way.