Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve cleanup-rootfs.sh #1630

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

karaketir16
Copy link
Contributor

Running docker image prune --all --force can save 2.5GB.

Total reclaimed space: 2.454GB

I am sending this as enabled to test with workflows. We can make it disabled by default like apt packages.

Or we can enable all, RM,APT,DOCKER and we can WAIT.
it lasts just 25s.
https://github.com/karaketir16/test-workflows/actions/runs/12079969301/job/33686630344#step:3:1

@TommyMurphyTM1234
Copy link
Collaborator

Is this PR still needed or is it made redundant by this one which has been merged?

@karaketir16
Copy link
Contributor Author

The existing cleanup is probably enough. This PR offers an additional cleanup that may be needed in the future.

function cleanup_docker()
{
	if [[ ${DOCKER} == 1 ]]; then
		docker image prune --all --force &
		if [[ ${WAIT} == 1 ]]; then
			wait
		fi
	fi
}

@TommyMurphyTM1234
Copy link
Collaborator

TommyMurphyTM1234 commented Jan 22, 2025

Thanks @karaketir16.

I'm a bit unclear on your comments here:

We can make it disabled by default like apt packages.

Or we can enable all, RM,APT,DOCKER and we can WAIT.

Is there any reason not to just rebase the PR and apply the latter change?

@karaketir16
Copy link
Contributor Author

I am not sure I did it correctly. I rebased my branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants