Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SpiSharedDevice #37

Merged
merged 1 commit into from
Aug 20, 2021
Merged

add SpiSharedDevice #37

merged 1 commit into from
Aug 20, 2021

Conversation

almindor
Copy link
Collaborator

@almindor almindor commented Jul 30, 2021 •
edited
Loading

See this issue for a long description.

This implementation keeps the main Spi struct usable directly as an exclusive device for backwards compatibility.

@almindor almindor changed the title [WIP] add SpiSharedDevice add SpiSharedDevice Aug 4, 2021
@almindor almindor marked this pull request as ready for review August 4, 2021 20:04
@almindor almindor force-pushed the shared_spi branch 2 times, most recently from fdc281e to 53a2857 Compare August 4, 2021 20:35
@almindor almindor requested a review from Disasm August 5, 2021 16:55
Disasm
Disasm reviewed Aug 8, 2021
View reviewed changes
src/spi/bus.rs Outdated Show resolved Hide resolved
Disasm
Disasm reviewed Aug 8, 2021
View reviewed changes
src/spi/bus.rs Outdated Show resolved Hide resolved
Disasm
Disasm reviewed Aug 8, 2021
View reviewed changes
src/spi/bus.rs Outdated Show resolved Hide resolved
Disasm
Disasm reviewed Aug 16, 2021
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@almindor almindor force-pushed the shared_spi branch 3 times, most recently from 692e6a3 to 1ae4d74 Compare August 17, 2021 17:28
@almindor almindor requested a review from dkhayes117 August 17, 2021 19:34
dkhayes117
dkhayes117 reviewed Aug 17, 2021
View reviewed changes
Copy link
Contributor

@dkhayes117 dkhayes117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I made one comment on whether the traits should be sealed.

src/spi/traits.rs Outdated Show resolved Hide resolved
dkhayes117
dkhayes117 approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@dkhayes117 dkhayes117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkhayes117 dkhayes117 merged commit 72a62e2 into master Aug 20, 2021
@almindor almindor deleted the shared_spi branch June 25, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Disasm Disasm Disasm left review comments

@dkhayes117 dkhayes117 dkhayes117 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@almindor @Disasm @dkhayes117