-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update embedded-hal dependency to 1.0.0-alpha.7 #42
Update embedded-hal dependency to 1.0.0-alpha.7 #42
Conversation
fc17703
to
4f0de03
Compare
Looking good! I wonder if we should wait for rust-embedded/embedded-hal#351 to land so we can update our SPI to it (since it's almost the same split). @Disasm what are your thoughts? |
@ahmedcharles we'll need to bump the MSRV for this as well, including the CI scripts to match. |
Sure, as I mentioned in another similar PR in a related repo, I'm just trying to get it all to compile/work before I propose a precise plan for releasing/merging it. I'm fine with updating to using the new SPI interface once it's in an alpha. |
46f6b64
to
2353623
Compare
2353623
to
a96104a
Compare
I'm going to merge this as a step to get |
@ahmedcharles I've had to revert this (and subsequent changes) since I found an odd problem with the SPI that only happened with release mode. I'm going to investigate in a new PR. There was also a logical error in the |
No description provided.