Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embedded-hal dependency to 1.0.0-alpha.7 #42

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

ahmedcharles
Copy link
Contributor

No description provided.

@ahmedcharles ahmedcharles force-pushed the embedded-hal-1.0-alpha branch from fc17703 to 4f0de03 Compare February 23, 2022 08:33
@almindor
Copy link
Collaborator

Looking good! I wonder if we should wait for rust-embedded/embedded-hal#351 to land so we can update our SPI to it (since it's almost the same split). @Disasm what are your thoughts?

@almindor
Copy link
Collaborator

@ahmedcharles we'll need to bump the MSRV for this as well, including the CI scripts to match.

@ahmedcharles
Copy link
Contributor Author

Sure, as I mentioned in another similar PR in a related repo, I'm just trying to get it all to compile/work before I propose a precise plan for releasing/merging it.

I'm fine with updating to using the new SPI interface once it's in an alpha.

@ahmedcharles ahmedcharles force-pushed the embedded-hal-1.0-alpha branch 2 times, most recently from 46f6b64 to 2353623 Compare March 3, 2022 23:20
@ahmedcharles ahmedcharles force-pushed the embedded-hal-1.0-alpha branch from 2353623 to a96104a Compare April 5, 2022 21:45
@almindor
Copy link
Collaborator

I'm going to merge this as a step to get embedded-hal to alpha.8 with the SPI split next (I'll try to get a PR for that going soon).

@almindor almindor merged commit 3d2f5a2 into riscv-rust:master Jun 20, 2022
almindor added a commit that referenced this pull request Jun 25, 2022
almindor added a commit that referenced this pull request Jun 25, 2022
@almindor
Copy link
Collaborator

@ahmedcharles I've had to revert this (and subsequent changes) since I found an odd problem with the SPI that only happened with release mode. I'm going to investigate in a new PR. There was also a logical error in the spi/bus.rs here the comparison should've been with iwrite. Even fixing that tho, the --release SPI failure was still there. I'll try to test these changes bit by bit to see where the problem occurs with the new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants