Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CSVs from Google Docs into repo #496

Closed
Timmmm opened this issue Dec 20, 2024 · 2 comments · Fixed by #497
Closed

Move CSVs from Google Docs into repo #496

Timmmm opened this issue Dec 20, 2024 · 2 comments · Fixed by #497

Comments

@Timmmm
Copy link
Contributor

Timmmm commented Dec 20, 2024

We probably shouldn't be downloading unversioned CSVs from Google Docs at this point...

I would suggest the simplest option for now is to vendor them in the repo and manually update them when necessary. Or just edit them in place with OpenOffice or whatever. You lose the colouring but everything else should work.

@Timmmm
Copy link
Contributor Author

Timmmm commented Dec 20, 2024

Ah wait never mind, I missed this comment:

# Rule to download CSVs. These files are checked in and only re-downloaded when you `make download`.

Nonetheless the spreadsheet seems to be out of date anyway now so maybe we should just remove it. make download doesn't seem to actually work, but if it did you get this diff:

-"vstidc","0xA80","vstid","H","Read: VS, Write: VS, <<asr_perm>>","tag=0, otherwise undefined","Update the CSR using <<SCADDR>>.","direct write","","","","✔","Zstid","Virtual supervisor thread ID","","","","","","","","","","","","","","","","","","","","",""
+"vstidc","0xA80","vstid","VS","Read: H, Write: H, <<asr_perm>>","tag=0, otherwise undefined","Update the CSR using <<SCADDR>>.","direct write","","","","✔","Zstid","Virtual supervisor thread ID","","","","","","","","","","","","","","","","","","","","",""

@tariqkurd-repo
Copy link
Collaborator

we need a replacement flow first, maintaining the CSV is a pain. It's just that an import is required following a bug fix by @francislaus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants