Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for downloading CSVs from Google Docs #497

Merged

Conversation

Timmmm
Copy link
Contributor

@Timmmm Timmmm commented Dec 20, 2024

The Google version hasn't been kept up to date with the version in the repo, and it's a bit weird to still have this anyway.

Fixes #496

The Google version hasn't been kept up to date with the version in the repo, and it's a bit weird to still have this anyway.
@tariqkurd-repo
Copy link
Collaborator

tariqkurd-repo commented Dec 20, 2024

There is one bug fix in the google sheet which hasn't made it to an MR yet - @francislaus are you planning to do that?
I'm not planning to remove the google sheet as maintaining the CSV without it will be a real pain, we'll need a flow for doing that (possibly to/from yaml) first.

@tariqkurd-repo tariqkurd-repo self-requested a review December 20, 2024 15:04
Copy link
Collaborator

@tariqkurd-repo tariqkurd-repo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not until a replacement flow is in place to allow easy maintainance.

@Timmmm
Copy link
Contributor Author

Timmmm commented Dec 20, 2024

You can edit the CSV directly using a CSV editor no? I don't see any features except for colours that are used in the Google Doc that aren't preserved in the CSV.

Here's one I like in VSCode:

image

It's write format doesn't quite match what Google Docs outputs (Google outputs ,"", for empty fields), but they seem to be on their own there. LibreOffice and Gnumeric and that extension just do ,, so I'd suggest just switching to that.

@arichardson
Copy link
Collaborator

I also think it's time to change the source of truth to be the repository. I can also edit the CSV as a table in Intellij:

image

We could convert it to YAML to make it easier to edit, but I'm not sure that's really necessary?

@tariqkurd-repo
Copy link
Collaborator

tariqkurd-repo commented Jan 2, 2025

We could convert it to YAML to make it easier to edit, but I'm not sure that's really necessary?

the point of yaml is to make the differences easier to spot, but as the spreadsheet is fairly small it's probably not so important

also the spreadsheet as a lot of repeated entries, which are lost when converting to CSV, so it's possible that text will diverge (e.g. a lot of CSRs have the same Update the CSR using <<SCADDR>>. text

Additionally, which is also important, a huge advantage of the spreadsheet is filtering and sorting columns which I can't obviously see how to do in EditCSV. The information is quite stable so maybe it's not so important not but these spreadsheet features have made a lot of difference when developing the spec.

It is of course possible to read the CSV into a spreadsheet to do that.

@tariqkurd-repo tariqkurd-repo self-requested a review January 2, 2025 10:15
@tariqkurd-repo tariqkurd-repo merged commit 557678b into riscv:main Jan 2, 2025
3 checks passed
@Timmmm Timmmm deleted the user/timh/remove_spreadsheet_download branch January 2, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move CSVs from Google Docs into repo
3 participants