Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unratified Zvamo instructions from rv_v #202

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

a4lg
Copy link
Contributor

@a4lg a4lg commented Oct 16, 2023

If this is the only thing happening, I would have just moved those instructions to unratified/rv_zvamo.

The reason I didn't is, there is the Zabha extension (containing subword AMO instructions) in the fast track and 8-bit vector AMO instructions conflict with it.

Instruction Source 31..27 26 25 24..20 19..15 14..12 11..7 6..0
vamoswapei8.v Zvamo (draft) 00001 wd vm vs2 vs1 000 vd 0101111
amoswap.b Zabha (fast track) 00001 aq rl rs2 rs1 000 rd 0101111

Related: riscv/riscv-zabha#17

@a4lg a4lg changed the title Remove unratified 'Zvamo' instructions from rv_v Remove unratified Zvamo instructions from rv_v Oct 16, 2023
If this is the only thing happening, I would have just moved those
instructions to unratified/rv_zvamo.  The reason I didn't is, there is
the 'Zabha' extension (containing subword AMO instructions) in the fast
track and 8-bit vector AMO instructions conflict with it.
@codecov-commenter
Copy link

Codecov Report

Merging #202 (2620b90) into master (edc1398) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files           3        3           
  Lines         636      636           
=======================================
  Hits          590      590           
  Misses         46       46           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will break Spike, so please also make a PR that removes the feature from Spike.

@aswaterman
Copy link
Member

Thanks for handling the Spike issue.

@aswaterman aswaterman merged commit d23e15c into riscv:master Oct 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants