Improved code-style and contribution documentation #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-requests ideally come with an explanation how the correctness of the PR was established.
|
Regarding the license part, I think the CI should just run make apply_header introduced in this PR pre merge: |
Does that always give the correct header? |
|
It just reads LICENCE file in the repo, and apply it to all the files. |
The sentence I added is weak so compatible with auto-adding headers. Just a reminder for people. |
|
Sounds good to me. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added notes about copyright headers in code, and a reminder that pull-requests ideally come with an explanation how the correctness of the PR was established.