fix: pulsar error during recovery #17112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make initial subscription mode to nondurable to avoid "Durable subscription with the same name already exists." error during recovery.
tabVersion
approved these changes
Jun 5, 2024
|
Is it ready to merge? It is the last outstanding cherry-pick to v1.9.1 |
Let's merge. Not a big change. |
|
Oh, I just realize that the longevity test locked the branch cc: @MrCroxx do you have the permission to merge it? |
Merged
via the queue into
risingwavelabs:main
with commit Jun 5, 2024
4d73f05
34 of 35 checks passed
lmatz
pushed a commit
that referenced
this pull request
Jun 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
Co-authored-by: Cherilyn Buren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make pulsar initial subscription mode to nondurable to avoid "Durable subscription with the same name already exists." error during recovery.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.