Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(risedev): bump cargo-make version #9366

Merged
merged 3 commits into from
Apr 24, 2023
Merged

chore(risedev): bump cargo-make version #9366

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd6b921
chore(risedev): bump cargo-make version
BugenZhao Apr 23, 2023
14a9033
use min_version instead
BugenZhao Apr 23, 2023
00fe287
specify patch version as well
BugenZhao Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions risedev
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#!/usr/bin/env bash

if [ -z "$(which cargo-make)" ]; then
if [[ $(cargo make --version) != "cargo-make 0.36"* ]]; then
Copy link
Member

@xxchan xxchan Apr 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>= ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to do ">" for semver in bash.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👼

echo "Installing cargo-make..."
cargo install cargo-make --version "^0.35" --locked
cargo install cargo-make --version "^0.36" --locked
Copy link
Member

@xxchan xxchan Apr 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be

Suggested change
cargo install cargo-make --version "^0.36" --locked
cargo install cargo-make --version "~0.36" --locked

?

Because the check is != "cargo-make 0.36"*

fi

touch risedev-components.user.env
Expand Down