Skip to content

Commit

Permalink
editor: NSlicer should not clamp children
Browse files Browse the repository at this point in the history 
This PR kinda reverts https://github.com/rive-app/rive/pull/8428 and adds few new things.
It also depends on https://github.com/rive-app/rive/pull/8447 landing first.

Previously I thought users would expect the NSlicedNode to control all vertices to be strictly within its bounds. Turns out there are use cases for vertices to translate outside, e.g. imagine a leaf animating outside.

This PR relaxes the requirement for vertices to be inside an NSlicedNode in the editor as well as the runtime.

Demo:
The left shows the behavior before this PR. Note that the two vertices outside of the bounds do not show. After this PR, they remain visible:
![a31](https://github.com/user-attachments/assets/41a34e9b-543c-417c-acf8-a273969874df)

Same demo in runtime:
![a3](https://github.com/user-attachments/assets/0d5cbb36-a0a8-42a6-a899-97dbe03ee420)

Diffs=
ce9e44c6b3 editor: NSlicer should not clamp children (#8459)
  • Loading branch information
susan101566 committed Nov 5, 2024
1 parent d2e8e8c commit 0512b25
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .rive_head
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
446682cda9f0e9f15bd12eef8bc405eec31a48fe
ce9e44c6b386d1a813689f6950b5ac59646ad265
2 changes: 1 addition & 1 deletion submodules/rive-runtime
Submodule rive-runtime updated 3 files
+1 −1 .rive_head
+0 −6 src/layout/n_sliced_node.cpp
+5 −0 src/math/n_slicer_helpers.cpp

0 comments on commit 0512b25

Please sign in to comment.