GH Actions for building Rive.xcframework #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat/automation
adamTrz
commented
Apr 29, 2021
adamTrz
commented
Apr 29, 2021
adamTrz
commented
Apr 29, 2021
|
@adamTrz we've made a ton of changes as we get the high level API in place; is this PR still valid for merging? |
Hey, @mjohnsullivan , GH Action code shouldn't be affected by changes in native code. They're separate :) |
|
Great! I notice that rive.h and Runtime.h is duplicated in a few places in this checkin. Is this intentional and if so, do we have to keep them in sync somehow? |
|
closing PR, its sibling is merged which has all the important stuff from here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automation PR that will build necessary frameworks and create a Pod repo from it.
On each GH Release we will create a
RiveRuntime.xcframeworkandRiveRuntime.podspec.Currently Pod is being created and uploaded to a GH repository from which it can be used in other projects (e.g. ExampleiOS). This can be changed in future - we can upload it to Cocoapods repo and download from there.