New constructors for RiveFile #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mjohnsullivan
commented
Jun 1, 2021
•
mjohnsullivan
commented
- Adds initWithResource contructor to RiveFile
- Adds initWithHttpUrl constructor to RiveFile and adds async loading support
mjtalbot
reviewed
Jun 2, 2021
| self.view = view | ||
| } | ||
| } | ||
|
|
||
| /* | ||
| class SimpleAnimationViewController: UIViewController { |
There was a problem hiding this comment.
nice. would almost have this as a 2nd standalone example
mjtalbot
reviewed
Jun 2, 2021
| * Creates a RiveFile from an HTTP url | ||
| */ | ||
| - (nullable instancetype)initWithHttpUrl:(NSString *)url withDelegate:(id<RiveFileDelegate>)delegate { | ||
| self.isLoaded = false; |
mjtalbot
reviewed
Jun 2, 2021
| @@ -60,6 +42,7 @@ - (nullable instancetype)initWithByteArray:(NSArray *)array { | |||
| }]; | |||
| rive::BinaryReader reader = [self getReader:bytes byteLength:array.count]; | |||
There was a problem hiding this comment.
need to make this non nullable
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.