Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more input types for application description #21

Closed
rivernews opened this issue Apr 18, 2019 · 5 comments
Closed

Allow more input types for application description #21

rivernews opened this issue Apr 18, 2019 · 5 comments
Labels
🔥Current Sprint Currently working on - hot in progress user reqeusted

Comments

@rivernews
Copy link
Owner

rivernews commented Apr 18, 2019

Current Behavior

  • Application has an input for a url link to the job description page.

Desired Behavior

  • Will be nice to have a textfield to have a short note for the application.
  • Also one user pointed out company may pull down the job description page once the interview starts. In such case there's no way to retrieve the description by url or online.
    • One suggestion the user gave is to allow screenshot image upload.

To sum up:

  • Image upload field
  • Textfield
@rivernews
Copy link
Owner Author

rivernews commented Apr 27, 2019

Ideal case: Scalable text field input

Ideally, the text field can contain rich content. If so, we can add link or even image then the image upload field is not needed.

But the application status link becomes less useful too. However, the status text can come in handy serving for tab labels. See issue for tab.

Workaround: simple text field

A pure text field may suffice a lot of needs.

If we move toward ideal case in the future, will it be backward compatible? Yes it will, those text will just be pure text in the editor, assuming we are introducing a rich text editor.

@rivernews rivernews added the 🔥Current Sprint Currently working on - hot in progress label Apr 27, 2019
@rivernews
Copy link
Owner Author

Implementation for workaround

  • Add the new field in backend model, for all company, application and application status.
  • Add new fields to serializer
  • Add new fields in frontend data models
  • Add new fields in frontend forms
  • Add new fields in frontend render components

@rivernews
Copy link
Owner Author

rivernews commented May 2, 2019

Working with tab when adding the text input type

One way to do it is

  • Make the current status text be used as simple text field.
  • At the company model level, add a status field for tab.
    • Whether we use the current many-to-many label field, or we use a new choice field, is however arguable.

@rivernews
Copy link
Owner Author

rivernews commented Sep 12, 2019

Update:

  • Status: may related to tabbed UI, can be done later. Hold on.
  • Rich text editor for application, or for company

Search for appropriate Rich Text Editor

Any tech stack constraints?

  • In React
  • Has typings for Typescript

Candidates

  • Ckeditor: great to have @ckeditor/ckeditor5-react @shaungc/ckeditor5-custom-balloon, but unfortunately, seems like ts typing not there yet.

@rivernews
Copy link
Owner Author

rivernews commented Sep 15, 2019

Add Rich Text Field for Application

Aspects

  • Frontend editor onkeyboardDown - update the data mechanism?
    • Should reside in form components now - scaffold a rich text field by shadowing existing field.
      • See how we can hook into our current form framework.
    • At the bottom - how to integrate with material components? --> We will consider this later
  • Frontend data model update?
  • Backend model
    • Add new field in model
  • Backend CRUD consideration?
    • Add new field to fields in serializer. That's all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥Current Sprint Currently working on - hot in progress user reqeusted
Projects
None yet
Development

No branches or pull requests

1 participant