Skip to content

Commit

Permalink
Fix get_events() unit test and add case to find_groups()
Browse files Browse the repository at this point in the history
 * get_events now tests the get_events call
 * added TODO's for future tests based on logical branches
 * find_groups now runs with and without optional params

Part of Issue #31
  • Loading branch information
missaugustina committed Apr 12, 2018
1 parent d67e66b commit bbfc85c
Show file tree
Hide file tree
Showing 4 changed files with 42 additions and 17 deletions.
Binary file added tests/testdata/httr_get_get_events.rda
Binary file not shown.
20 changes: 17 additions & 3 deletions tests/testthat/test-find_groups.R
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,30 @@ context("find_groups")

test_that("find_groups() success case", {

meetup_groups <- with_mock(
`httr::GET` = function(url, query, ...) {
load(here::here("tests/testdata/httr_get_find_groups.rda"))
return(req)
},
meetup_groups <- find_groups(api_key = "R-Ladies FTW!")
)

expect_equal(nrow(meetup_groups), 1, label="check find_groups() returns one result")
expect_equal(meetup_groups$name, "R-Ladies London", label="check find_groups() content (name)")
})

test_that("find_groups() with parameters", {

meetup_groups <- with_mock(
`httr::GET` = function(url, query, ...) {
print(getwd())

This comment has been minimized.

Copy link
@missaugustina

missaugustina Apr 12, 2018

Author Member

Whoops, left some debug code.

load(here::here("tests/testdata/httr_get_find_groups.rda"))
return(req)
},
meetup_groups <- find_groups(api_key = "R-Ladies FTW!",
text = "hihi")
text = "hihi", radius = "foo")
)

expect_equal(nrow(meetup_groups), 1, label="check find groups returns one result")
expect_equal(meetup_groups$name, "R-Ladies London", label="check find groups content (name)")
expect_equal(nrow(meetup_groups), 1, label="check find_groups() returns one result")
expect_equal(meetup_groups$name, "R-Ladies London", label="check find_groups() content (name)")
})
35 changes: 21 additions & 14 deletions tests/testthat/test-get_events.R
Original file line number Diff line number Diff line change
@@ -1,18 +1,25 @@
context("get_events")

test_that(".quick_fetch() works properly", {
skip_on_travis()
skip_on_cran()
api_key <- Sys.getenv("MEETUP_KEY")
event_status <- "past"
urlname <- Sys.getenv("MEETUP_NAME")
meetup_api_prefix <- "https://api.meetup.com/"
api_url <- paste0(meetup_api_prefix, urlname, "/events")
test_that("get_events() success case", {
meetup_events <- with_mock(
`httr::GET` = function(url, query, ...) {
print(getwd())

This comment has been minimized.

Copy link
@missaugustina

missaugustina Apr 12, 2018

Author Member

NooOo! More debug code.

load(here::here("tests/testdata/httr_get_get_events.rda"))
return(req)
},
meetup_events <- get_events(api_key="yay",
urlname = "<3",
event_status = "upcoming")
)

res <- .quick_fetch(api_url = api_url,
api_key = api_key,
event_status = event_status)
total_records <- as.integer(res$headers$`x-total-count`)
length_results <- length(res$result)
expect_equal(total_records,length_results)
expect_equal(nrow(meetup_events), 1, label="check get_events() returns one result")
expect_equal(meetup_events$status, "upcoming", label="check get_events() content (status)")
})

# TODO: multiple statuses

# TODO: event type is not allowed

# TODO: "urlname is missing"


4 changes: 4 additions & 0 deletions tests/testthat/test-internals.R
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,7 @@ test_that(".quick_fetch() success case", {
expect_equal(names(res), c("result", "headers"), info="check .quick_fetch() return value")
expect_equal(res$headers$`content-type`, "application/json;charset=utf-8", info="check .quick_fetch() header content-type")
})

# TODO .fetch_results()

# TODO .fetch_results() no api key

0 comments on commit bbfc85c

Please sign in to comment.