Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing AgentManager for ExperimentManager #336

Closed
TimotheeMathieu opened this issue Jul 12, 2023 · 2 comments · Fixed by #350
Closed

Changing AgentManager for ExperimentManager #336

TimotheeMathieu opened this issue Jul 12, 2023 · 2 comments · Fixed by #350
Assignees
@RemyDegenne
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers Marathon To do during Marathon

Comments

@TimotheeMathieu
Copy link
Collaborator

Na
@omardrwch
Copy link
Member

Just a comment for when it is done, we can keep an alias AgentManager = ExperimentManager with a deprecation warning, to avoid breaking existing code.

@KohlerHECTOR
Copy link
Collaborator

Just a change of name but still need to be careful .

@KohlerHECTOR KohlerHECTOR reopened this Jul 13, 2023
@KohlerHECTOR KohlerHECTOR added documentation Improvements or additions to documentation good first issue Good for newcomers Marathon To do during Marathon labels Jul 13, 2023
@RemyDegenne RemyDegenne self-assigned this Jul 24, 2023
@RemyDegenne RemyDegenne mentioned this issue Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RemyDegenne RemyDegenne

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers Marathon To do during Marathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename AgentManager to ExperimentManager
4 participants
@RemyDegenne @omardrwch @TimotheeMathieu @KohlerHECTOR