Rename AgentManager to ExperimentManager #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
RemyDegenne
changed the title
6 tasks
|
Expect for codecov, lgtm. We should merge. |
TimotheeMathieu
approved these changes
Jul 24, 2023
JulienT01
added a commit
to JulienT01/rlberry
that referenced
this pull request
Jul 25, 2023
JulienT01
added a commit
to JulienT01/rlberry
that referenced
this pull request
Jul 28, 2023
JulienT01
added a commit
that referenced
this pull request
Jul 12, 2024
* Updated eval() and policy() docstring of agent * Update docstring for eval_agents in manager * update docstring on agent * update docstring on agentTorch * Removed redundancy in docstring * update name in docstring following PR350: #350 * update kwargs and docstring * docstring : gym.Env -> gymnasium.Env * remove old warning (tests on P3.10 are ok) * update names following PR350(part2): #350 * Userguide : Save & Load Agents * userguide : read_writer_data * add information on why seeding is important. Issue #465 * add test on seeding (no seeds => different results) * update seeding userguide * remove ExperimentManager seed with adastop add a warning when it remove the seed add test to check the warning * add information about the default writer * update read_writer_date to correct bug with 'str' datasource * add tests for read_writer_data --------- Co-authored-by: brahimdriss <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: brahimdriss <[email protected]> Co-authored-by: Waris Radji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename AgentManager to ExperimentManager everywhere.
Rename RemoteAgentManager to RemoteExperimentManager.
Closes #336
Checklist
To check :
black --check examples rlberry *py
flake8 --select F401,F405,D410,D411,D412 --exclude=rlberry/check_packages.py --per-file-ignores="init.py:F401",