-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Allows to build NNs in A2C from a string equal to the function's name #180
Conversation
I think I got some warning but I am not sure if I should worry. It says stuff like "Added line #L117 was not covered by tests". Do you know why? |
It is not a big problem it is just that in the test for A2C, policy_net_fn was always the default I guess so it does not test policy_net_fn which is string or callable. rlberry/rlberry/tests/test_agent.py Line 53 in 85176de
|
@TimotheeMathieu I added some checks and is fine now. Thank you! |
Allows to build value_net_fn and policy_net_fn from a string using rlberry.utils.factory.load. This is useful when you want to
call model_factory_from_env to build the architectures from a .yaml file according to args specified therein