Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Development of v0.2.2 (part 1) #83

Merged
merged 7 commits into from
Jan 10, 2022
Merged

[WIP] Development of v0.2.2 (part 1) #83

merged 7 commits into from
Jan 10, 2022

Conversation

omardrwch
Copy link
Member

@omardrwch omardrwch commented Dec 9, 2021

Bug fixes:

  • Fixed bug in FiniteMDP.sample(): terminal state was being checked with self.state instead of given state

Features:

  • Option to use 'fork' or 'spawn' in AgentManager
  • AgentManager output_dir now has a timestamp and a short ID by default.

TODO:

  • Utils for checkpoint
  • Gridworld from string layout

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #83 (25a12f8) into main (2ac9baa) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 25a12f8 differs from pull request most recent head 2916253. Consider uploading reports for the commit 2916253 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   78.71%   78.66%   -0.05%     
==========================================
  Files         159      159              
  Lines        8438     8438              
==========================================
- Hits         6642     6638       -4     
- Misses       1796     1800       +4     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
rlberry/envs/finite/finite_mdp.py 100.00% <100.00%> (ø)
rlberry/exploration_tools/torch/rnd.py 70.19% <0.00%> (-2.89%) ⬇️
rlberry/exploration_tools/typing.py 90.69% <0.00%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac9baa...2916253. Read the comment docs.

@omardrwch omardrwch changed the title [Do not merge] Development of v0.2.2 [WIP] Development of v0.2.2 Jan 7, 2022
@omardrwch omardrwch merged commit 3801c69 into main Jan 10, 2022
@omardrwch omardrwch changed the title [WIP] Development of v0.2.2 [WIP] Development of v0.2.2 (part 1) Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant