modification to domain.py and additional printing of result filenames #2
Conversation
drexlerd
commented
Oct 25, 2021
drexlerd
commented
- some domains in domain.py were modified and some were added
- the generate-all-instances.py now prints a list of the filenames generated
| @@ -226,8 +224,7 @@ def adapt_parameters_tidybot(parameters): | |||
|
|
|||
| Tasks: | |||
| agricola: 67 | |||
| mystery: 492 | |||
| pathways: 114 | |||
| mystery: 492gnum_keytypes | |||
There was a problem hiding this comment.
Can you revert this change, please?
| parameters["locks"] = int( | ||
| parameters["x"] * parameters["y"] * parameters["percentage_cells_locked"] | ||
| ) | ||
| parameters["locks"] = max(parameters["locks"], parameters["shapes"]) |
There was a problem hiding this comment.
Are these adaptations obsolete?
src/domains.py
Outdated
| get_int("drivers", lower=4, upper=5), | ||
| get_int("packages", lower=4, upper=5), | ||
| get_int("roadjunctions", lower=4, upper=5), | ||
| get_int("trucks", lower=4, upper=5), |
There was a problem hiding this comment.
We'll have to find a better mechanism for supporting different parameter sets. For now, let's use a single set of parameter values that are (expected to be) useful for SSE for all domains.
src/domains.py
Outdated
| get_int("y", lower=2, upper=3), | ||
| get_int("shapes", lower=1, upper=2), | ||
| get_enum("keys", choices=["0", "1", "2", "20", "02", "11"]), | ||
| get_enum("prob_key_in_goal", choices=[100]), |
There was a problem hiding this comment.
Why did you switch from the Python to the C generator?
| [ | ||
| get_int("num_objects", lower=1, upper=5), | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Please order the domains by name.
| shutil.rmtree(tmp_dir, ignore_errors=False) | ||
| print([os.path.splitext(problem_name)[0] for problem_name in problem_names if problem_name is not None]) |
There was a problem hiding this comment.
Let's use pathlib for path manipulations instead of os.path.
There was a problem hiding this comment.
What do you use this list for? I'm a bit skeptical to print this list, since it will dominate the whole output.
