Migrate to mise for local/CI and bump versions #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally I wouldn't want to introduce an extra dependency in CI, but I think this would be extremely easy to undo if it ever started to cause problems. The main reason to use it in actions is to avoid declaring tool versions in two places that need to be kept in sync. The major benefit here is that for tools like golangci-lint and goreleaser, we now use an official release binary rather than building from source, which was never officially supported or recommended. Not that it's caused problems yet, but better to play it safe. This also has the benefit of ensuring that the version of golangci-lint that runs in my editor is the same as the version the project wants me to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally I wouldn't want to introduce an extra dependency in CI, but I think this would be extremely easy to undo if it ever started to cause problems. The main reason to use it in actions is to avoid declaring tool versions in two places that need to be kept in sync.
The major benefit here is that for tools like golangci-lint and goreleaser, we now use an official release binary rather than building from source, which was never officially supported or recommended. Not that it's caused problems yet, but better to play it safe.
This also has the benefit of ensuring that the version of golangci-lint that runs in my editor is the same as the version the project wants me to use.