dup String in strip_string

rmm5t · Nov 17, 2022 · 7004e43 · 7004e43
1 parent 37c1cb2
commit 7004e43
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/strip_attributes.rb b/lib/strip_attributes.rb
@@ -52,7 +52,7 @@ def self.strip_record(record, options = {})
 
   def self.strip_string(value, options = {})
     return value unless value.is_a?(String)
-    return value if value.frozen?
+    value = value.dup
 
     allow_empty      = options[:allow_empty]
     collapse_spaces  = options[:collapse_spaces]

diff --git a/test/strip_attributes_test.rb b/test/strip_attributes_test.rb
@@ -204,10 +204,12 @@ def test_should_strip_and_allow_empty
     assert_equal "",            record.bang
   end
 
-  def test_should_skip_frozen_values
-    record = StripAllMockRecord.new(frozen: " ice ".freeze)
+  def test_should_not_mutate_values
+    record = StripAllMockRecord.new(foo: " foo ")
+    old_value = record.foo
     record.valid?
-    assert_equal " ice ", record.frozen
+    assert_equal "foo",        record.foo
+    refute_equal old_value,    record.foo
   end
 
   def test_should_collapse_duplicate_spaces