Regression in 1.9.1: Arrays & Hashes now become nil #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! It appears that #47 (released in v1.9.1) causes a change from previous behavior.
In v1.9.0 & prior, converting
.blank?
->nil
was implicitly limited to Strings because those were conditional onif value.respond_to?(:strip)
.#47 separated the
.blank?
test fromrespond_to?(:strip)
which now causes non-Strings, such as Hashes and Arrays, to also be converted tonil
.This PR adds a check that an attribute is a String before running
strip_string()
, which matches the prior behavior.Side note: this would likely allow many of the other
respond_to?()
tests to be dropped, but that seemed out of scope to be including here.