-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move google/protobuf
requirement to dev
#14
base: 1.x
Are you sure you want to change the base?
Conversation
WalkthroughThe changes involve updates to the Changes
Sequence Diagram(s)(No sequence diagrams generated as the changes do not involve new features or modifications to control flow.) Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
composer.json (1)
Line range hint
1-58
: More information is needed to address the exception handling requirement.The PR summary mentions that you are seeking assistance in identifying the appropriate location within the autogenerated classes to implement exception handling for missing Protobuf components. However, the provided code changes do not include any exception handling logic.
To help with this requirement, please provide more information on the specific autogenerated classes and the desired behavior for the exception handling. Once you provide more details, I can assist in identifying the appropriate location for implementing the exception handling logic.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- composer.json (1 hunks)
Additional comments not posted (3)
composer.json (3)
36-36
: LGTM!The addition of
ext-protobuf
torequire-dev
enhances clarity regarding development dependencies.
40-41
: LGTM!The changes to the
suggest
section improve the documentation and organization of the dependency requirements.
42-42
: LGTM!The addition of a version constraint and description for
google/protobuf
in thesuggest
section enhances clarity regarding its role in Protobuf codec support.
google/protobuf
requirement to dev
@msmakouz could you please take a look? |
Hello.
Trying to do the same as in the repository https://github.com/roadrunner-php/goridge -
google/protobuf
is removed fromrequire_dev
and added tosuggest
ext-protobuf
as well. The purpose is not to installgoogle/protobuf
whenext-protobuf
already installed.However, I can not add an exception throw same as here: https://github.com/roadrunner-php/goridge/blob/8fe68b0c871862f9ec852659de1cc7c1a68b783f/src/RPC/Codec/ProtobufCodec.php#L26
All class are autogenerated, trying to find out where to make an user-friendly exception if nothing is installed. Need assistance c:
cc @Kaspiman
Summary by CodeRabbit