Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disallow unwrap and expect except in tests #286

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

spencewenski
Copy link
Member

There are a couple places where we do allow expect, but these places should mainly be during boot up and not during normal app operations, and their usage should be minimal.

There are a couple places where we do allow `expect`, but these places
should mainly be during boot up and not during normal app operations,
and their usage should be minimal.
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.80%. Comparing base (50a17b2) to head (cad0b3f).

Files Coverage Δ
src/service/http/middleware/size_limit.rs 64.15% <100.00%> (+0.68%) ⬆️
src/service/grpc/service.rs 0.00% <0.00%> (ø)
src/service/runner.rs 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a17b2...cad0b3f. Read the comment docs.

@spencewenski spencewenski merged commit 999f362 into main Jul 23, 2024
15 checks passed
@spencewenski spencewenski deleted the disallow-unwrap branch July 23, 2024 19:40
@github-actions github-actions bot mentioned this pull request Jul 24, 2024
spencewenski pushed a commit that referenced this pull request Jul 24, 2024
## 🤖 New release
* `roadster`: 0.5.8 -> 0.5.9

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.5.9](roadster-v0.5.8...roadster-v0.5.9)
- 2024-07-24

### Added
- Auto-update timestamp columns
([#287](#287))
- Add SeaORM migrations and utils to create `user` table
([#284](#284))

### Other
- Disallow `unwrap` and `expect` except in tests
([#286](#286))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant