feat: Provide and ProvideRef traits to provide AppContext objects
#510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, annotate with `mockall::automock` when the new `testing-mocks` feature is enabled to allow consumers to easily provide mocks to methods expecting a trait impl.
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
Merged
spencewenski
added a commit
that referenced
this pull request
Nov 16, 2024
## 🤖 New release * `roadster`: 0.6.18 -> 0.6.19 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.6.19](roadster-v0.6.18...roadster-v0.6.19) - 2024-11-16 ### Added - `Provide` and `ProvideRef` traits to provide `AppContext` objects ([#510](#510)) ### Other - Use justfile command to run coverage ([#509](#509)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Spencer Ferris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, annotate with
mockall::automockwhen the newtesting-mocksfeature is enabled to allow consumers to easily provide mocks to methods expecting a trait impl.This is significantly simpler than mocking the
AppContextstruct itself, so we will not do that for now. We can consider doing it later if people really want it.Closes #495