chore!: Remove From<Environment> impl for &'static str
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencewenski
pushed a commit
that referenced
this pull request
Jan 19, 2025
## 🤖 New release * `roadster`: 0.7.0-alpha.1 -> 0.7.0-alpha.2 (⚠️ API breaking changes) ###⚠️ `roadster` breaking changes ``` --- failure enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_missing.ron Failed in: enum roadster::util::serde_util::UriOrString, previously in file /tmp/.tmpfJfcaO/roadster/src/util/serde.rs:41 enum roadster::migration::schema::Timestamps, previously in file /tmp/.tmpfJfcaO/roadster/src/migration/timestamp/mod.rs:11 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/function_missing.ron Failed in: function roadster::util::serde_util::deserialize_from_str, previously in file /tmp/.tmpfJfcaO/roadster/src/util/serde.rs:12 function roadster::migration::schema::pk_bigint_auto, previously in file /tmp/.tmpfJfcaO/roadster/src/migration/schema.rs:47 function roadster::util::serde_util::serialize_to_str, previously in file /tmp/.tmpfJfcaO/roadster/src/util/serde.rs:28 function roadster::util::serde_util::default_true, previously in file /tmp/.tmpfJfcaO/roadster/src/util/serde.rs:56 function roadster::migration::schema::pk_uuidv7, previously in file /tmp/.tmpfJfcaO/roadster/src/migration/schema.rs:162 function roadster::migration::schema::pk_uuidv4, previously in file /tmp/.tmpfJfcaO/roadster/src/migration/schema.rs:135 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/inherent_method_missing.ron Failed in: AppConfig::new, previously in file /tmp/.tmpfJfcaO/roadster/src/config/mod.rs:141 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/module_missing.ron Failed in: mod roadster::config::app_config, previously in file /tmp/.tmpfJfcaO/roadster/src/config/app_config.rs:1 mod roadster::util::serde_util, previously in file /tmp/.tmpfJfcaO/roadster/src/util/serde.rs:1 --- failure pub_module_level_const_missing: pub module-level const is missing --- Description: A public const is missing, renamed, or changed from const to static. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/pub_module_level_const_missing.ron Failed in: ENV_VAR_SEPARATOR in file /tmp/.tmpfJfcaO/roadster/src/config/mod.rs:115 ENV_VAR_PREFIX in file /tmp/.tmpfJfcaO/roadster/src/config/mod.rs:114 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/struct_missing.ron Failed in: struct roadster::config::app_config::AppConfig, previously in file /tmp/.tmpfJfcaO/roadster/src/config/mod.rs:42 struct roadster::config::app_config::CustomConfig, previously in file /tmp/.tmpfJfcaO/roadster/src/config/mod.rs:87 struct roadster::config::app_config::App, previously in file /tmp/.tmpfJfcaO/roadster/src/config/mod.rs:364 ``` <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.7.0-alpha.2](roadster-v0.7.0-alpha.1...roadster-v0.7.0-alpha.2) - 2025-01-18 ### Added - Map `Error::Auth` to `StatusCode::UNAUTHORIZED` HTTP response (#571) - [**breaking**] Return `RedisEnqueue` and `RedisFetch` redis pool "new-types" (#568) ### Other - Remove todos (#570) - [**breaking**] Remove `From<Environment>` impl for `&'static str` (#569) - Declare all dependencies in workspace (#567) - [**breaking**] Remove deprecated items (#566) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.