Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RBStoryboardModalSegue loading two of the same controllers, causing performance issues #46

Open
kliffy opened this issue Nov 20, 2014 · 2 comments
Open

RBStoryboardModalSegue loading two of the same controllers, causing performance issues #46

kliffy opened this issue Nov 20, 2014 · 2 comments

Comments

@kliffy
Copy link

kliffy commented Nov 20, 2014

noticed this when my modals using RBStoryboardModalSegue were taking abnormally long.

line 148 of RBStoryboardLink.m "self.preferredContentSize = scene.preferredContentSize;" is causing the second to be loaded
@zhfish
Copy link
Contributor

zhfish commented Dec 1, 2014

i will pull request the question

zhfish added a commit to zhfish/RBStoryboardLink that referenced this issue Dec 1, 2014
@zhfish
rob-brown#45 Fix to retrieve modal presentation attributes
21f65c2 
rob-brown#46 Fix double times initWithDecoder
@zhfish zhfish mentioned this issue Dec 1, 2014
Merged
@mykoma
Copy link

mykoma commented Jan 12, 2015

Works for me.

thanks

rob-brown added a commit that referenced this issue Feb 7, 2015
@rob-brown
Merge pull request #48 from zhfish/pr
7c743b4 
#45 #46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zhfish @mykoma @kliffy