Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard input in REAPER does not work #38

Closed
robbert-vdh opened this issue Sep 29, 2020 · 2 comments
Closed

Keyboard input in REAPER does not work #38

robbert-vdh opened this issue Sep 29, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@robbert-vdh
Copy link
Owner

robbert-vdh commented Sep 29, 2020

Keyboard input in REAPER currently does not work. The window handling in REAPER is quite different from some other DAWs which complicates things a little. Alt-tabbing out of the plugin window and then alt-tabbing back in again will enable keyboard focus, but that's definitely not how things should work. I have not yet come up with a way around this other than aggressively grabbing keyboard focus whenever you hover your mouse over the window, which is not a great solution.

@robbert-vdh robbert-vdh added the bug Something isn't working label Sep 29, 2020
robbert-vdh added a commit that referenced this issue Sep 30, 2020
This fixes keyboard input in REAPER, and I haven't found any downsides
to this approach yet.
@robbert-vdh robbert-vdh added the fixed-in-master This feature request or bug has been fixed in the master branch. label Sep 30, 2020
@robbert-vdh
Copy link
Owner Author

robbert-vdh commented Oct 8, 2020

This issue also affected Ardour in some instances. I'm currently going through a bunch of plugins to see if they all work as expected in all different hosts with the new input focus grabbing method. The current fix does not seem to work reliably with Melda's 'F1' help dialogs in REAPER and Ardour, so I'm still working on that.

EDIT: As of e680f2e this should now work again. I'll have to do some more rigorous testing to see if this does not introduce any regressions elsewhere.

EDIT2: I ended up completely rewriting how keyboard input is handled to be simpler, more reliable, and to be able to give input focus back to the host when needed (can be useful in REAPER). This seems to fix all issues with REAPER and Ardour, and hotkeys in Bitwig while the editor window is open now also work again, but it will require some more testing to see if this does not cause any unwanted behaviour.

@robbert-vdh
Copy link
Owner Author

Now that yabridge 1.7.0 is out this should be resolved. Please let me know if anyone's having any other keyboard input related issues.

@robbert-vdh robbert-vdh removed the fixed-in-master This feature request or bug has been fixed in the master branch. label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant