Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single list for Ingestion Model and adapted tests #121

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Single list for Ingestion Model and adapted tests #121

merged 6 commits into from
Jul 31, 2024

Conversation

vyvytranngoc
Copy link
Contributor

PR Context

Added

Changes

  • BulkIngestRequest contains now one single list "items"
  • tests for ingestion adapted to BulkIngestRequest-Model

Deprecated

Removed

  • removed class _BaseBulkIngestRequest for ingestion model

Fixed

Security

cutoffthetop
cutoffthetop requested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@cutoffthetop cutoffthetop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also nice, thank you! removing a bunch of overcomplicated code, makes this endpoint+connector code much nicer to read and use.

i have just 2 further simplification ideas

mex/backend/ingest/main.py Outdated Show resolved Hide resolved
tests/ingest/test_models.py Show resolved Hide resolved
vyvytranngoc and others added 2 commits July 31, 2024 15:33
@vyvytranngoc @cutoffthetop
Update mex/backend/ingest/main.py
5dc5fe0 
Co-authored-by: Nicolas Drebenstedt <[email protected]>
Signed-off-by: vyvytranngoc <[email protected]>
@vyvytranngoc
Merge branch 'main' into feature/mx-1563-single-list-type-discriminator
b6d372b 
# Conflicts:
#	CHANGELOG.md
#	mex/backend/ingest/main.py
cutoffthetop
cutoffthetop reviewed Jul 31, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
cutoffthetop
cutoffthetop approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@cutoffthetop cutoffthetop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good 🚢

@vyvytranngoc vyvytranngoc merged commit 6f2655e into main Jul 31, 2024
7 checks passed
@vyvytranngoc vyvytranngoc deleted the feature/mx-1563-single-list-type-discriminator branch July 31, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cutoffthetop cutoffthetop cutoffthetop approved these changes

Assignees

@vyvytranngoc vyvytranngoc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyvytranngoc @cutoffthetop