Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1381 rework database model #25

Merged
merged 69 commits into from
Apr 8, 2024
Merged

feature/mx-1381 rework database model #25

merged 69 commits into from
Apr 8, 2024

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Jan 26, 2024 •
edited
Loading

PR Context

  • to run: set MEX_IDENTITY_PROVIDER = "graph"

Changes

  • re-implemented queries as templated cql files
  • updated graph connector for new queries
  • improved isolation of neo4j dependency
  • improved documentation and code-readability

Removed

  • trashed hydration module

@cutoffthetop cutoffthetop self-assigned this Jan 26, 2024
@cutoffthetop cutoffthetop marked this pull request as ready for review February 15, 2024 16:24
@cutoffthetop cutoffthetop mentioned this pull request Feb 16, 2024
Merged
Base automatically changed from feature/mx-1533-graph-id-provider to main February 19, 2024 14:06
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 27, 2024
View reviewed changes
poetry.lock Fixed Show resolved Hide resolved
@cutoffthetop cutoffthetop force-pushed the feature/mx-1381-prep-rule-endpoint branch from d8e93f4 to 71d44c2 Compare March 27, 2024 17:03
@cutoffthetop cutoffthetop mentioned this pull request Mar 27, 2024
Closed
@cutoffthetop
Copy link
Contributor Author

One general remark: please add your changes to the changelog.

done in c004b98

rababerladuseladim
rababerladuseladim requested changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@rababerladuseladim rababerladuseladim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost!

Tests fail locally, e.g. tests/extracted/test_main.py::test_search_extracted_items[full text search]. Looks like identifier and stableTargetId are somehow mixed up.

mex/backend/graph/connector.py Outdated Show resolved Hide resolved
@cutoffthetop cutoffthetop mentioned this pull request Apr 3, 2024
Closed
@cutoffthetop
Copy link
Contributor Author

Tests fail locally, e.g. tests/extracted/test_main.py::test_search_extracted_items[full text search]. Looks like identifier and stableTargetId are somehow mixed up.

hm yeah, there were some test isolation issues, fixed those in 3fb35d5

rababerladuseladim
rababerladuseladim approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@rababerladuseladim rababerladuseladim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cutoffthetop cutoffthetop merged commit e8ec12a into main Apr 8, 2024
7 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1381-prep-rule-endpoint branch April 8, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rababerladuseladim rababerladuseladim rababerladuseladim approved these changes

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cutoffthetop @rababerladuseladim