Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1649 prevent and subtract #192

Merged
merged 84 commits into from
Jan 22, 2025
Merged

feature/mx-1649 prevent and subtract #192

merged 84 commits into from
Jan 22, 2025

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Nov 11, 2024 •
edited
Loading

PR Context

  • for local testing, needs a backend started with debug=True and identity_provider=graph
  • removed localization of temporals because those don't convert back to rules that easily. let's wait until localization becomes a hard requirement

Added

  • add toggles for preventive and subtractive rules
  • add functionality to edit component for submitting rules
  • add utility function to escalate errors to all consoles
  • temporarily add BackendIdentityProvider (stop-gap MX-1763)

Changes

  • rename FixedX and EditableX classes to EditorX for consistency

Removed

  • drop dev-dependency to mex-backend, use the flush endpoint instead
  • temporarily removed localization of temporals entity output

cutoffthetop and others added 30 commits September 18, 2024 14:43
@cutoffthetop
first draft
8ca3090
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-ed…
35601ab 
…itor into feature/mx-1702-resolve-types
@cutoffthetop
wip
7256377
@cutoffthetop
rework, prepare, clean
686f79e
@cutoffthetop
add temporal case and up tests
f49a9d4
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-ed…
2555b67 
…itor into feature/mx-1702-resolve-types
@cutoffthetop
lock
30b7fc4
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-ed…
a3790f1 
…itor into feature/mx-1702-resolve-types
@cutoffthetop
lock
55aaa63
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-ed…
872108f 
…itor into feature/mx-1702-resolve-types
@cutoffthetop
fix merge
49969ca
@cutoffthetop
lock
167cb37
@cutoffthetop
lock and lint
c07ccde
@cutoffthetop
fix handler
2493f98
@cutoffthetop
update common, pin requests
f7c03fd
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-ed…
6ef1c5a 
…itor into feature/mx-1702-resolve-types
@cutoffthetop
fix tests
13e72cc
@cutoffthetop
lint
0724548
@cutoffthetop
fix test
54aa8b1
@cutoffthetop
CL
1199332
@cutoffthetop
fix tests
b55ea66
@cutoffthetop
include all pngs
621efbb
@cutoffthetop @fdiehr
feature/model update v3 (#137)
9acc637 
# PR Context
- needs robert-koch-institut/mex-common#207

# Added
<!-- New features and interfaces -->

# Changes
- updated the model config for preview of search results for model v3

# Deprecated
<!-- Soon-to-be removed features -->

# Removed
<!-- Definitely removed features -->

# Fixed
<!-- Fixed bugs -->

# Security
<!-- Fixed vulnerabilities -->

Co-authored-by: Franziska Diehr <[email protected]>
@cutoffthetop
fix yaml
4069837
@cutoffthetop
Merge branch 'feature/mx-1702-resolve-types' of https://github.com/ro…
abed263 
…bert-koch-institut/mex-editor into feature/mx-1702-resolve-types
@cutoffthetop
CL
078887f
@cutoffthetop
try multiprocessing.Process
14df0c5
@cutoffthetop
add ResettingGraphConnector to fix tests
891d955
@cutoffthetop
enhance log msgs
3ee21ba
@cutoffthetop
make frontend_url a fixture for tests
99fc450
cutoffthetop added a commit to robert-koch-institut/mex-backend that referenced this pull request Dec 19, 2024
@cutoffthetop
feature/mx-1649 more rule prep (#220)
d73b25f 
# PR Context
- another prep for
robert-koch-institut/mex-editor#192

# Added
- configure backoff rules for graph commits
- validate that the number of merged edges is as intended
- implement graph flushing connector method
- add endpoint for flushing the neo4j database (when running in debug)

# Changes
<!-- Changes in existing functionality -->

# Deprecated
<!-- Soon-to-be removed features -->

# Removed
- remove open-api schema customization, not needed anymore by the
current editor
- remove purge-script, this is an HTTP endpoint now

# Fixed
<!-- Fixed bugs -->

# Security
<!-- Fixed vulnerabilities -->
@cutoffthetop cutoffthetop mentioned this pull request Dec 20, 2024
Closed
1 task
rababerladuseladim
rababerladuseladim requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@rababerladuseladim rababerladuseladim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow...

tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
mex/editor/edit/main.py Show resolved Hide resolved
mex/editor/transform.py Show resolved Hide resolved
mex/editor/edit/transform.py Outdated Show resolved Hide resolved
mex/editor/edit/transform.py Outdated Show resolved Hide resolved
mex/editor/identity.py Outdated Show resolved Hide resolved
tests/edit/test_main.py Show resolved Hide resolved
@cutoffthetop cutoffthetop merged commit cad7ddc into main Jan 22, 2025
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1649-prevent-and-subtract branch January 22, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rababerladuseladim rababerladuseladim rababerladuseladim approved these changes

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cutoffthetop @rababerladuseladim @RKIMetadataExchange